Add zh, zh-Hans-CN, and zh-Hant-TW #1520
Open
+816
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, thanks. I just sent #1522 as a pure cherry-pick of the commit that went into v0.0.29. If we merge that first, then that will facilitate comparing v0.0.29 with upcoming versions in main; it should also simplify this change somewhat by taking care of most of the unrelated changes that had accumulated. |
PIG208
changed the title
|
This is also an experiment of how Weblate processes new languages we added. I suppose |
Normally, instead of doing it manually, we would add new languages from Weblate's UI. In this case, the ones added in this commit are not offered there. So we will commit this to GitHub first, and let Weblate pull the changes from there. The language identifier zh is left empty, and is set to be ignored on Weblate for translations. Translator will be expected translate strings for zh-Hans-CN and zh-Hant-TW instead. We can add more locales with the zh language code if users request them. See CZO discussion on how we picked these language identifiers: https://chat.zulip.org/#narrow/channel/58-translation/topic/zh_*.20in.20Weblate/near/2177452
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds app_zh.arb so that locales like "zh-Hans-CN" can have their
code generated.
This is because
flutter gen-l10nrequires a base locale to be present.Only having "zh-Hans-CN" and "zh-Hant-TW" and gives us the following error.
"zh" will not appear on Weblate, though, because we exclude it from
settings. This is intentional since it only makes sense to translate
the more specific locales like "zh-Hans-CN" and "zh-Hant-TW".
CZO discussion:
https://chat.zulip.org/#narrow/channel/58-translation/topic/zh_*.20in.20Weblate/near/2174667
The following are screenshots from my Android device, with different system language preferences set.
(zh-Hant-HK resolves to zh-Hant-TW)